Page MenuHomePhabricator

Add a preference to disable ghost comments
ClosedPublic

Authored by epriestley on May 4 2015, 6:55 PM.
Tags
None
Referenced Files
F15466880: D12704.id30502.diff
Thu, Apr 3, 10:33 AM
F15466806: D12704.id30502.diff
Thu, Apr 3, 9:59 AM
F15466164: D12704.id.diff
Thu, Apr 3, 2:21 AM
F15465367: D12704.diff
Wed, Apr 2, 5:52 PM
F15420869: D12704.id30502.diff
Fri, Mar 21, 6:26 PM
F15388087: D12704.id30504.diff
Sat, Mar 15, 3:18 AM
F15301371: D12704.id.diff
Mar 5 2025, 5:45 PM
F15285275: D12704.diff
Mar 4 2025, 12:35 PM

Details

Summary

Ref T7447. At least some users dislike this feature so strongly that they'd prefer not to have it at all.

Test Plan

Viewed ghosts; toggled preference, no more ghosts.

Diff Detail

Repository
rP Phabricator
Branch
ghost2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5744
Build 5763: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add a preference to disable ghost comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

We could add an "Only if not Done" option easily, but bringing "Done" comments forward is so valuable for me that it's hard for me to imagine that this is really a useful setting.

I could perhaps imagine an "On revisions I am the author of, only if not Done" setting, but this seems too complicated and confusing.

chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.