Page MenuHomePhabricator

Provide link to inlines in-context in $ghost['href']
ClosedPublic

Authored by epriestley on May 4 2015, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 8:45 AM
Unknown Object (File)
Sat, Feb 15, 11:30 PM
Unknown Object (File)
Wed, Feb 12, 3:16 AM
Unknown Object (File)
Sat, Feb 8, 4:17 AM
Unknown Object (File)
Sat, Feb 8, 4:17 AM
Unknown Object (File)
Jan 24 2025, 4:00 AM
Unknown Object (File)
Jan 24 2025, 4:00 AM
Unknown Object (File)
Jan 22 2025, 11:11 AM

Details

Summary

See D12702.

Test Plan

Made something a link and clicked it, seemed to work OK.

Diff Detail

Repository
rP Phabricator
Branch
ghost1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5742
Build 5761: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Provide link to inlines in-context in $ghost['href'].
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 6:48 PM
This revision was automatically updated to reflect the committed changes.

It’d be nice if the link also changed the background color to yellow like we do transaction links.

Yeah, I think it's hypothetically supposed to but that code has been a bit finnicky in the past. I'll file something and look into it.