Page MenuHomePhabricator
Differential D12703

Provide link to inlines in-context in $ghost['href']
ClosedPublic
Actions

Authored by epriestley on May 4 2015, 6:45 PM.
Tags
None
Referenced Files
F15522932: D12703.id30499.diff
Sun, Apr 20, 10:32 PM
F15482153: D12703.id30501.diff
Wed, Apr 9, 3:25 AM
F15469335: D12703.id.diff
Fri, Apr 4, 12:09 PM
F15467646: D12703.diff
Thu, Apr 3, 5:12 PM
F15466947: D12703.id30499.diff
Thu, Apr 3, 11:04 AM
F15466946: D12703.id30501.diff
Thu, Apr 3, 11:04 AM
F15466945: D12703.id.diff
Thu, Apr 3, 11:04 AM
F15466805: D12703.diff
Thu, Apr 3, 9:59 AM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP460d68ba27b6: Provide link to inlines in-context in $ghost['href']
Summary

See D12702.

Test Plan

Made something a link and clicked it, seemed to work OK.

Diff Detail

Repository
rP Phabricator
Branch
ghost1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5742
Build 5761: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30499.May 4 2015, 6:45 PM
epriestley retitled this revision from to Provide link to inlines in-context in $ghost['href'].
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added subscribers: epriestley, yelirekim. · View Herald TranscriptMay 4 2015, 6:45 PM
epriestley mentioned this in D12702: Remove click to view on ghosties.May 4 2015, 6:45 PM
chad accepted this revision.May 4 2015, 6:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 6:48 PM
Closed by commit rP460d68ba27b6: Provide link to inlines in-context in $ghost['href'] (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 6:52 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.May 4 2015, 6:59 PM

It’d be nice if the link also changed the background color to yellow like we do transaction links.

epriestley added a comment.May 4 2015, 7:00 PM

Yeah, I think it's hypothetically supposed to but that code has been a bit finnicky in the past. I'll file something and look into it.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
6 lines
6 lines
query/
9 lines
storage/
3 lines

Diff 30499

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility