Differential D12698

Remove hook functionality
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 3:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 29, 7:01 PM

	Unknown Object (File)
	Tue, Jan 28, 11:45 PM

	Unknown Object (File)
	Sat, Jan 25, 9:21 AM

	Unknown Object (File)
	Sat, Jan 25, 8:53 AM

	Unknown Object (File)
	Fri, Jan 24, 3:59 AM

	Unknown Object (File)
	Fri, Jan 24, 3:59 AM

	Unknown Object (File)
	Fri, Jan 24, 3:59 AM

	Unknown Object (File)
	Fri, Jan 24, 12:44 AM

Subscribers

Tokens

"Piece of Eight" token, awarded by btrahan."Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7674: Remove support for arc commit hooks

Commits

rARC8919a9c5b55e: Remove hook functionality

Summary

Fixes T7674. Remove remaining commit hook functionality.

Test Plan

Unit tests still pass?

Diff Detail

Repository

Branch

hook

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5735
Build 5754: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,067 ms	ArcanistPuppetLintLinterTestCase::testLinter
	777 ms	ArcanistXMLLinterTestCase::testLinter
	1,251 ms	ArcanistCSSLintLinterTestCase::testLinter
	242 ms	ArcanistCSSLintLinterTestCase::testVersion
	232 ms	ArcanistChmodLinterTestCase::testLinter
		View Full Test Results (2 Failed · 52 Passed · 5 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30482.May 4 2015, 3:01 PM

joshuaspence retitled this revision from to Remove hook functionality.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7674: Remove support for arc commit hooks.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 3:01 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 4 2015, 3:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 4 2015, 3:03 PM

epriestley awarded a token.May 4 2015, 3:03 PM

btrahan awarded a token.May 4 2015, 4:48 PM

joshuaspence added a parent revision: D12712: Remove "commit hook mode" check from Javelin linter.May 5 2015, 11:03 AM

Closed by commit rARC8919a9c5b55e: Remove hook functionality (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 12:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

3 lines

lint/

engine/

ArcanistLintEngine.php

52 lines

linter/

ArcanistLinter.php

9 lines

__tests__/

ArcanistLinterTestCase.php

3 lines

spelling/

spell.lint-test

5 lines

repository/

api/

ArcanistGitAPI.php

13 lines

hookapi/

ArcanistHookAPI.php

ArcanistSubversionHookAPI.php

Diff 30482

src/__phutil_library_map__.php

Loading...

src/lint/engine/ArcanistLintEngine.php

Loading...

src/lint/linter/ArcanistLinter.php

Loading...

src/lint/linter/tests/ArcanistLinterTestCase.php

Loading...

src/lint/linter/tests/spelling/spell.lint-test

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/repository/hookapi/ArcanistHookAPI.php

Loading...

src/repository/hookapi/ArcanistSubversionHookAPI.php

Loading...