Page MenuHomePhabricator
Differential D12693

Add some missing type hints
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 1:38 PM.
Tags
None
Referenced Files
F13233509: D12693.diff
Tue, May 21, 2:22 AM
F13189624: D12693.diff
Sat, May 11, 6:15 AM
Unknown Object (File)
Wed, May 1, 12:30 AM
Unknown Object (File)
Apr 21 2024, 11:38 PM
Unknown Object (File)
Apr 9 2024, 9:46 AM
Unknown Object (File)
Apr 8 2024, 8:51 PM
Unknown Object (File)
Apr 8 2024, 8:51 PM
Unknown Object (File)
Apr 8 2024, 8:43 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU21268aff1d8a: Add some missing type hints
Summary

Add some type hints for Remarkup rules.

Test Plan

Browsed around some Remarkup text.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5726
Build 5745: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30473.May 4 2015, 1:38 PM
joshuaspence retitled this revision from to Add some missing type hints.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 1:38 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 4 2015, 1:39 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 1:39 PM
Closed by commit rPHU21268aff1d8a: Add some missing type hints (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30473

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupBoldRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupDelRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupItalicRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupMonospaceRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupUnderlineRule.php

Loading...
Phabricator · Built by Phacility