Page MenuHomePhabricator

Fix FontAwesome fonts in Firefox
ClosedPublic

Authored by chad on Apr 30 2015, 9:59 PM.
Tags
None
Referenced Files
F13236530: D12635.diff
Tue, May 21, 10:00 AM
F13223143: D12635.diff
Sun, May 19, 4:19 AM
F13198470: D12635.diff
Mon, May 13, 6:57 AM
F13175143: D12635.diff
Wed, May 8, 3:37 AM
Unknown Object (File)
Fri, May 3, 5:19 AM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Apr 13 2024, 2:05 AM
Unknown Object (File)
Apr 11 2024, 8:37 AM
Subscribers

Details

Summary

Fixes T7983. Moves FontAwesome to only affect the :before attribute, which all icons are based on.

Test Plan

Tested Chrome, Safari, Firefox on Mac. Chrome, Firefox, IE on Windows.

Diff Detail

Repository
rP Phabricator
Branch
firefoxfonts
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5629
Build 5648: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Fix FontAwesome fonts in Firefox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2015, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Should probably roll secure, I'm going to test some more edge case browsers.