Page MenuHomePhabricator
Differential D12522

Adds a setLabel function to ActionView
ClosedPublic
Actions

Authored by chad on Apr 23 2015, 5:17 AM.
Tags
None
Referenced Files
F13119957: D12522.diff
Mon, Apr 29, 3:45 PM
Unknown Object (File)
Sat, Apr 27, 12:39 AM
Unknown Object (File)
Wed, Apr 24, 11:43 PM
Unknown Object (File)
Thu, Apr 11, 12:51 AM
Unknown Object (File)
Sun, Mar 31, 11:03 PM
Unknown Object (File)
Mar 12 2024, 9:47 PM
Unknown Object (File)
Mar 1 2024, 10:28 PM
Unknown Object (File)
Feb 11 2024, 9:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP91714568f56b: Adds a setLabel function to ActionView
Summary

I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too.

Test Plan

Built and tested on the search ui dropdown.

pasted_file (313×279 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Branch
action-view-dropdown
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5461
Build 5479: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30062.Apr 23 2015, 5:17 AM
chad retitled this revision from to Adds a setLabel function to ActionView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 23 2015, 5:17 AM
chad edited the test plan for this revision. (Show Details)Apr 23 2015, 5:17 AM
chad updated this revision to Diff 30063.Apr 23 2015, 5:19 AM
  • derpsies
epriestley accepted this revision.Apr 23 2015, 9:37 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 9:37 AM
Closed by commit rP91714568f56b: Adds a setLabel function to ActionView (authored by chad, committed by chad). · Explain WhyApr 23 2015, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
46 lines
src/
view/
layout/
12 lines
webroot/
rsrc/
css/
phui/
19 lines
js/
core/
2 lines
phuix/
10 lines

Diff 30063

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorActionView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-list.css

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility