Page MenuHomePhabricator

Quicksand - update help appropriately as you navigate about
ClosedPublic

Authored by btrahan on Apr 22 2015, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 10:03 AM
Unknown Object (File)
Tue, Apr 30, 5:15 PM
Unknown Object (File)
Tue, Apr 30, 5:15 PM
Unknown Object (File)
Tue, Apr 30, 5:15 PM
Unknown Object (File)
Tue, Apr 30, 5:15 PM
Unknown Object (File)
Mon, Apr 29, 2:33 PM
Unknown Object (File)
Thu, Apr 25, 3:29 AM
Unknown Object (File)
Fri, Apr 5, 10:00 AM
Subscribers

Details

Summary

Fixes T7724. Things are a bit tricky here as sometimes we don't want to display the help icon at all...! Change things such that we always render at least the icon, though it may have the style set to hidden if appropriate. Instrument quicksand javascript to then load the proper help dropdown if it can. Do this generally so other aphlict dropdowns could work pretty easily.

Test Plan

started on home and noted no help. clicked maniphest and saw maniphest help. clicked home and saw no help again. clicked differential and saw differential help.

Diff Detail

Repository
rP Phabricator
Branch
T7724
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5428
Build 5446: [Placeholder Plan] Wait for 30 Seconds