Page MenuHomePhabricator

Modernize DifferentialInlineCommentQuery
ClosedPublic

Authored by epriestley on Apr 20 2015, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 5:47 PM
Unknown Object (File)
Wed, Jan 29, 2:35 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Tue, Jan 21, 11:08 AM
Unknown Object (File)
Sun, Jan 19, 3:26 AM
Unknown Object (File)
Fri, Jan 17, 4:37 PM

Details

Summary

Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.

Try to generalize/normalize it a bit.

Test Plan
  • Viewed inline comments.
  • Created a new inline comment.
  • Edited an inline comment.
  • Marked an inline comment complete.
  • Deleted, then undeleted an inline comment.
  • Previewed inline comments.
  • Viewed drafts as another user, verified they don't show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize DifferentialInlineCommentQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.