Page MenuHomePhabricator

Modernize DifferentialInlineCommentQuery
ClosedPublic

Authored by epriestley on Apr 20 2015, 9:36 PM.
Tags
None
Referenced Files
F18834790: D12483.diff
Sun, Oct 26, 10:50 AM
F18820412: D12483.id.diff
Wed, Oct 22, 2:49 PM
F18817917: D12483.diff
Tue, Oct 21, 7:28 PM
F18801572: D12483.id.diff
Fri, Oct 17, 6:10 PM
F18735785: D12483.id29970.diff
Wed, Oct 1, 3:17 AM
F18698965: D12483.id29993.diff
Sep 27 2025, 12:06 PM
F18631455: D12483.id29993.diff
Sep 16 2025, 3:24 PM
F18590516: D12483.diff
Sep 12 2025, 6:17 AM

Details

Summary

Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.

Try to generalize/normalize it a bit.

Test Plan
  • Viewed inline comments.
  • Created a new inline comment.
  • Edited an inline comment.
  • Marked an inline comment complete.
  • Deleted, then undeleted an inline comment.
  • Previewed inline comments.
  • Viewed drafts as another user, verified they don't show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize DifferentialInlineCommentQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.