Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.
Try to generalize/normalize it a bit.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7447: Bring inline comments forward across revision updates
- Commits
- Restricted Diffusion Commit
rP5645a07d9984: Modernize DifferentialInlineCommentQuery
- Viewed inline comments.
- Created a new inline comment.
- Edited an inline comment.
- Marked an inline comment complete.
- Deleted, then undeleted an inline comment.
- Previewed inline comments.
- Viewed drafts as another user, verified they don't show up.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ghost1
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/query/DifferentialInlineCommentQuery.php:9 XHP16 TODO Comment Advice src/applications/differential/query/DifferentialInlineCommentQuery.php:86 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 5407 Build 5425: [Placeholder Plan] Wait for 30 Seconds