Page MenuHomePhabricator
Differential D12482

Add contextual typeahead function documentation
ClosedPublic
Actions

Authored by epriestley on Apr 20 2015, 7:37 PM.
Tags
None
Referenced Files
F14844457: D12482.diff
Sun, Feb 2, 3:58 PM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Fri, Jan 24, 2:50 AM
Unknown Object (File)
Wed, Jan 22, 6:56 PM
Unknown Object (File)
Thu, Jan 16, 5:11 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPbae0a85dbc52: Add contextual typeahead function documentation
Summary

Ref T4100. This integration into the "Browse" dialog is probably a little more heavy-handed than we should shoot for.

Test Plan

Screen_Shot_2015-04-20_at_12.34.50_PM.png (463×609 px, 52 KB)

Screen_Shot_2015-04-20_at_12.37.21_PM.png (1×1 px, 263 KB)

Diff Detail

Repository
rP Phabricator
Branch
logic14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5405
Build 5423: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29965.Apr 20 2015, 7:37 PM
epriestley retitled this revision from to Add contextual typeahead function documentation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2015, 7:37 PM
chad edited edge metadata.Apr 20 2015, 7:43 PM

Can we float some text in the footer opposite of the close button?

epriestley added a comment.Apr 20 2015, 7:49 PM

Screen_Shot_2015-04-20_at_12.48.43_PM.png (426×614 px, 50 KB)

epriestley updated this revision to Diff 29966.Apr 20 2015, 7:53 PM
epriestley edited edge metadata.
  • Use a footer instead.
chad accepted this revision.Apr 20 2015, 8:30 PM
chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/typeahead/ManiphestNoOwnerDatasource.php
32

return return

This revision is now accepted and ready to land.Apr 20 2015, 8:30 PM
epriestley updated this revision to Diff 29968.Apr 20 2015, 8:42 PM
epriestley marked an inline comment as done.
epriestley edited edge metadata.
  • Return less returns.
Closed by commit rPbae0a85dbc52: Add contextual typeahead function documentation (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29966

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestNoOwnerDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php

Loading...
View Options

src/applications/typeahead/application/PhabricatorTypeaheadApplication.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
Phabricator · Built by Phacility