Page MenuHomePhabricator

Add contextual typeahead function documentation
ClosedPublic

Authored by epriestley on Apr 20 2015, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 4:20 PM
Unknown Object (File)
Feb 24 2024, 12:35 AM
Unknown Object (File)
Feb 16 2024, 5:48 AM
Unknown Object (File)
Feb 3 2024, 3:21 AM
Unknown Object (File)
Jan 25 2024, 7:53 PM
Unknown Object (File)
Jan 12 2024, 5:46 AM
Unknown Object (File)
Dec 30 2023, 6:35 PM
Unknown Object (File)
Dec 29 2023, 11:36 AM
Subscribers

Details

Summary

Ref T4100. This integration into the "Browse" dialog is probably a little more heavy-handed than we should shoot for.

Test Plan

Screen_Shot_2015-04-20_at_12.34.50_PM.png (463×609 px, 52 KB)

Screen_Shot_2015-04-20_at_12.37.21_PM.png (1×1 px, 263 KB)

Diff Detail

Repository
rP Phabricator
Branch
logic14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5406
Build 5424: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add contextual typeahead function documentation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.

Can we float some text in the footer opposite of the close button?

epriestley edited edge metadata.
  • Use a footer instead.
chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/typeahead/ManiphestNoOwnerDatasource.php
32

return return

This revision is now accepted and ready to land.Apr 20 2015, 8:30 PM
epriestley marked an inline comment as done.
epriestley edited edge metadata.
  • Return less returns.
This revision was automatically updated to reflect the committed changes.