Page MenuHomePhabricator
Differential D12468

Implement readProjectsFromRequest() helper for SearchEngines
ClosedPublic
Actions

Authored by epriestley on Apr 19 2015, 2:16 PM.
Tags
None
Referenced Files
F13159192: D12468.id29922.diff
Mon, May 6, 12:13 AM
Unknown Object (File)
Mon, Apr 29, 5:06 AM
Unknown Object (File)
Sun, Apr 28, 1:02 AM
Unknown Object (File)
Sat, Apr 27, 6:41 PM
Unknown Object (File)
Thu, Apr 25, 12:07 AM
Unknown Object (File)
Wed, Apr 17, 1:35 AM
Unknown Object (File)
Fri, Apr 12, 7:43 AM
Unknown Object (File)
Thu, Apr 11, 8:24 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPb85f8b91de69: Implement readProjectsFromRequest() helper for SearchEngines
Summary

Ref T4100. This just makes the "specify stuff in query parameters" workflow a little better:

  • You can now do ?projects=differential,diffusion.
  • You can now do ?projects=projects(alincoln).
Test Plan

Did that stuff ^^^^

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29922.Apr 19 2015, 2:16 PM
epriestley retitled this revision from to Implement readProjectsFromRequest() helper for SearchEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2015, 2:16 PM
btrahan accepted this revision.Apr 20 2015, 4:48 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phid/PhabricatorPHIDConstants.php
5

Nice, though random ish.

This revision is now accepted and ready to land.Apr 20 2015, 4:48 PM
epriestley added inline comments.Apr 20 2015, 4:53 PM
src/applications/phid/PhabricatorPHIDConstants.php
5

Yeah -- I nuked one elsewhere in this diff and grepped for it and saw no more uses.

Not sure why it stuck around so long; must have been a merge issue or maybe we cleaned up the rest of it without realizing it.

Closed by commit rPb85f8b91de69: Implement readProjectsFromRequest() helper for SearchEngines (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
5 lines
phid/
1 line
project/
typeahead/
38 lines
search/
engine/
70 lines

Diff 29959

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/phid/PhabricatorPHIDConstants.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility