Page MenuHomePhabricator

Implement readProjectsFromRequest() helper for SearchEngines
ClosedPublic

Authored by epriestley on Apr 19 2015, 2:16 PM.
Tags
None
Referenced Files
F12836167: D12468.id.diff
Thu, Mar 28, 3:38 PM
Unknown Object (File)
Sat, Mar 23, 5:57 PM
Unknown Object (File)
Feb 24 2024, 12:34 AM
Unknown Object (File)
Feb 3 2024, 3:19 AM
Unknown Object (File)
Feb 2 2024, 10:32 PM
Unknown Object (File)
Jan 16 2024, 9:38 PM
Unknown Object (File)
Jan 12 2024, 5:45 AM
Unknown Object (File)
Dec 30 2023, 5:37 PM
Subscribers

Details

Summary

Ref T4100. This just makes the "specify stuff in query parameters" workflow a little better:

  • You can now do ?projects=differential,diffusion.
  • You can now do ?projects=projects(alincoln).
Test Plan

Did that stuff ^^^^

Diff Detail

Repository
rP Phabricator
Branch
logic11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5385
Build 5403: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Implement readProjectsFromRequest() helper for SearchEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phid/PhabricatorPHIDConstants.php
5

Nice, though random ish.

This revision is now accepted and ready to land.Apr 20 2015, 4:48 PM
src/applications/phid/PhabricatorPHIDConstants.php
5

Yeah -- I nuked one elsewhere in this diff and grepped for it and saw no more uses.

Not sure why it stuck around so long; must have been a merge issue or maybe we cleaned up the rest of it without realizing it.

This revision was automatically updated to reflect the committed changes.