Paths

Table of Contentst

Differential D12474

Provide a getProjectRoot method for ArcanistLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 20 2015, 9:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 10, 1:34 PM

	Unknown Object (File)
	Sun, Feb 2, 9:12 AM

	Unknown Object (File)
	Thu, Jan 30, 1:16 PM

	Unknown Object (File)
	Wed, Jan 29, 7:18 AM

	Unknown Object (File)
	Tue, Jan 28, 7:37 AM

	Unknown Object (File)
	Wed, Jan 22, 12:45 PM

	Unknown Object (File)
	Tue, Jan 21, 3:30 PM

	Unknown Object (File)
	Tue, Jan 21, 3:18 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC1d72cfc94421: Provide a getProjectRoot method for ArcanistLinter

Summary

Adds a getProjectRoot() method to the ArcanistLinter class, simplifying a bunch of code.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5392
Build 5410: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,029 ms	ArcanistPuppetLintLinterTestCase::testLinter
	969 ms	ArcanistCSSLintLinterTestCase::testLinter
	182 ms	ArcanistCSSLintLinterTestCase::testVersion
	122 ms	ArcanistChmodLinterTestCase::testLinter
	228 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29932.Apr 20 2015, 9:19 AM

joshuaspence retitled this revision from to Provide a getProjectRoot method for ArcanistLinter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2015, 9:19 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Rebase

Rebase

epriestley accepted this revision.May 19 2015, 3:13 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/ArcanistLinter.php
92	state exception

This revision is now accepted and ready to land.May 19 2015, 3:13 PM

Closed by commit rARC1d72cfc94421: Provide a getProjectRoot method for ArcanistLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistExternalLinter.php

8 lines

ArcanistLinter.php

14 lines

ArcanistPyLintLinter.php

8 lines

ArcanistScriptAndRegexLinter.php

2 lines

ArcanistSpellingLinter.php

2 lines

Diff 29932

src/lint/linter/ArcanistExternalLinter.php

Loading...

src/lint/linter/ArcanistLinter.php

Loading...

src/lint/linter/ArcanistPyLintLinter.php

Loading...

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...

src/lint/linter/ArcanistSpellingLinter.php

Loading...