Page MenuHomePhabricator

Give typeahead browse dialogs sensible titles
ClosedPublic

Authored by epriestley on Apr 19 2015, 2:33 PM.
Tags
None
Referenced Files
F14844431: D12469.diff
Sun, Feb 2, 3:51 PM
Unknown Object (File)
Wed, Jan 29, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 9:11 PM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Wed, Jan 22, 9:22 AM
Unknown Object (File)
Fri, Jan 17, 5:14 PM
Subscribers

Details

Summary

Ref T4100. Let datasources specify a more meaningful title than the class name.

Test Plan

Browsed some sources.

Diff Detail

Repository
rP Phabricator
Branch
logic12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5386
Build 5404: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Give typeahead browse dialogs sensible titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
chad added a subscriber: chad.
chad added inline comments.
src/applications/people/typeahead/PhabricatorViewerDatasource.php
7

Is this a browse interface of one item?

This revision is now accepted and ready to land.Apr 19 2015, 2:38 PM

Yeah, the viewer(), viewerprojects() and null() datasources all return only one item. Users can never normally hit these browse dialogs unless they're developing/debugging, though.

This revision was automatically updated to reflect the committed changes.