Page MenuHomePhabricator

Give typeahead browse dialogs sensible titles
ClosedPublic

Authored by epriestley on Apr 19 2015, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 9:36 PM
Unknown Object (File)
Feb 24 2024, 12:34 AM
Unknown Object (File)
Feb 18 2024, 2:25 AM
Unknown Object (File)
Feb 3 2024, 3:19 AM
Unknown Object (File)
Jan 26 2024, 5:38 PM
Unknown Object (File)
Jan 19 2024, 7:28 AM
Unknown Object (File)
Jan 15 2024, 9:44 PM
Unknown Object (File)
Jan 12 2024, 5:45 AM
Subscribers

Details

Summary

Ref T4100. Let datasources specify a more meaningful title than the class name.

Test Plan

Browsed some sources.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give typeahead browse dialogs sensible titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
chad added a subscriber: chad.
chad added inline comments.
src/applications/people/typeahead/PhabricatorViewerDatasource.php
7

Is this a browse interface of one item?

This revision is now accepted and ready to land.Apr 19 2015, 2:38 PM

Yeah, the viewer(), viewerprojects() and null() datasources all return only one item. Users can never normally hit these browse dialogs unless they're developing/debugging, though.

This revision was automatically updated to reflect the committed changes.