Page MenuHomePhabricator
Differential D12466

Move setup issue callout to under the header
ClosedPublic
Actions

Authored by chad on Apr 19 2015, 4:08 AM.
Tags
None
Referenced Files
F14347139: D12466.diff
Thu, Dec 19, 2:42 AM
Unknown Object (File)
Sat, Dec 7, 1:36 PM
Unknown Object (File)
Fri, Dec 6, 5:30 AM
Unknown Object (File)
Wed, Nov 27, 8:35 PM
Unknown Object (File)
Tue, Nov 19, 4:06 PM
Unknown Object (File)
Nov 12 2024, 2:41 PM
Unknown Object (File)
Oct 22 2024, 3:26 PM
Unknown Object (File)
Oct 19 2024, 12:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins
Commits
Restricted Diffusion Commit
rP2106a553e4d8: Move setup issue callout to under the header
Summary

Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans.

Test Plan

Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc.

Screen_Shot_2015-04-18_at_9.04.30_PM.png (1×2 px, 372 KB)

Screen_Shot_2015-04-18_at_9.04.15_PM.png (1×2 px, 384 KB)

Screen_Shot_2015-04-18_at_9.04.24_PM.png (754×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Branch
setup-issue
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5383
Build 5401: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29916.Apr 19 2015, 4:08 AM
chad retitled this revision from to Move setup issue callout to under the header.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 19 2015, 4:08 AM
chad edited the test plan for this revision. (Show Details)Apr 19 2015, 4:09 AM
chad updated this revision to Diff 29917.Apr 19 2015, 4:13 AM
  • Conpherence was still funky
chad updated this revision to Diff 29918.Apr 19 2015, 4:15 AM
  • Well I don't know what the fuck I'm doing
chad updated this object.Apr 19 2015, 4:16 AM
chad added a comment.Apr 19 2015, 4:20 AM

I'm going to go play Hearthstone

chad updated this revision to Diff 29919.Apr 19 2015, 4:46 AM
  • moar conphencerecence
chad added a comment.Apr 19 2015, 4:49 AM

Resolved a number of non-obvious Conpherence bugs with the current iteration as well.

chad added a comment.Apr 19 2015, 4:50 AM

Going back to Hearthstone.

epriestley accepted this revision.Apr 19 2015, 12:50 PM
epriestley edited edge metadata.

I still favor just making this a menu item, but if this solves all problems forever...

This revision is now accepted and ready to land.Apr 19 2015, 12:50 PM
chad added a comment.Apr 19 2015, 2:15 PM

my only concern with a menu item is it would be non-obvious and very ignorable. maybe some future Rooster System?

I am willing to say this is my last attempt before moving it somewhere else.

Closed by commit rP2106a553e4d8: Move setup issue callout to under the header (authored by chad, committed by chad). · Explain WhyApr 19 2015, 2:16 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Apr 19 2015, 2:17 PM

I'm not above making it flicker rapidly or giving it an animation.

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
src/
view/
page/
4 lines
webroot/
rsrc/
css/
application/
base/
9 lines
conpherence/
4 lines
4 lines
9 lines
core/
2 lines
phui/
4 lines

Diff 29919

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workboard-view.css

Loading...
Phabricator · Built by Phacility