Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins
- Commits
- Restricted Diffusion Commit
rP2106a553e4d8: Move setup issue callout to under the header
Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- setup-issue
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5383 Build 5401: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Resolved a number of non-obvious Conpherence bugs with the current iteration as well.
Comment Actions
I still favor just making this a menu item, but if this solves all problems forever...
Comment Actions
my only concern with a menu item is it would be non-obvious and very ignorable. maybe some future Rooster System?
I am willing to say this is my last attempt before moving it somewhere else.