Page MenuHomePhabricator

Move setup issue callout to under the header
ClosedPublic

Authored by chad on Apr 19 2015, 4:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:04 PM
Unknown Object (File)
Feb 12 2024, 7:48 PM
Unknown Object (File)
Feb 8 2024, 5:08 PM
Unknown Object (File)
Feb 5 2024, 9:21 AM
Unknown Object (File)
Feb 3 2024, 3:19 AM
Unknown Object (File)
Feb 3 2024, 3:19 AM
Unknown Object (File)
Feb 3 2024, 3:18 AM
Unknown Object (File)
Feb 3 2024, 3:18 AM
Subscribers

Details

Summary

Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans.

Test Plan

Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc.

Screen_Shot_2015-04-18_at_9.04.30_PM.png (1×2 px, 372 KB)

Screen_Shot_2015-04-18_at_9.04.15_PM.png (1×2 px, 384 KB)

Screen_Shot_2015-04-18_at_9.04.24_PM.png (754×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Branch
setup-issue
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5380
Build 5398: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Move setup issue callout to under the header.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Conpherence was still funky
  • Well I don't know what the fuck I'm doing

I'm going to go play Hearthstone

Resolved a number of non-obvious Conpherence bugs with the current iteration as well.

epriestley edited edge metadata.

I still favor just making this a menu item, but if this solves all problems forever...

This revision is now accepted and ready to land.Apr 19 2015, 12:50 PM

my only concern with a menu item is it would be non-obvious and very ignorable. maybe some future Rooster System?

I am willing to say this is my last attempt before moving it somewhere else.

This revision was automatically updated to reflect the committed changes.

I'm not above making it flicker rapidly or giving it an animation.