Differential D12447

Make Differential use viewer's token instead of viewer() token again
ClosedPublic
Actions

Authored by epriestley on Apr 17 2015, 2:56 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4100: Support query parameterization in typeaheads

Commits

Restricted Diffusion Commit
rPea97d75a6775: Make Differential use viewer's token instead of viewer() token again

Summary

Ref T4100. This restores the simpler behavior. See discussion in T4100#107445

Test Plan

Used Differential search, saw my token.

Diff Detail

Repository

rP Phabricator

Branch

type16

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5354
Build 5372: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29869.Apr 17 2015, 2:56 PM

epriestley retitled this revision from to Make Differential use viewer's token instead of viewer() token again.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4100: Support query parameterization in typeaheads.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 17 2015, 2:56 PM

btrahan accepted this revision.Apr 17 2015, 5:31 PM

btrahan awarded a token.

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2015, 5:31 PM

Closed by commit rPea97d75a6775: Make Differential use viewer's token instead of viewer() token again (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

2 lines

Diff 29869

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Make Differential use viewer's token instead of viewer() token againClosedPublicActions