Page MenuHomePhabricator

Add a linter rule for alias functions
ClosedPublic

Authored by joshuaspence on Apr 15 2015, 1:28 PM.
Tags
None
Referenced Files
F15406270: D12422.id30995.diff
Tue, Mar 18, 12:19 PM
F15387051: D12422.id.diff
Sat, Mar 15, 1:44 AM
F15353115: D12422.diff
Mon, Mar 10, 8:04 PM
F15342637: D12422.diff
Sun, Mar 9, 9:13 PM
Unknown Object (File)
Tue, Feb 25, 6:29 PM
Unknown Object (File)
Feb 17 2025, 1:33 AM
Unknown Object (File)
Feb 17 2025, 12:55 AM
Unknown Object (File)
Feb 8 2025, 3:44 AM
Subscribers

Details

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_ALIAS_FUNCTION for linting the use of alias funtions. Based on Generic_Sniffs_PHP_ForbiddenFunctionsSniff. See list of function aliases.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5322
Build 5340: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for alias functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 1:29 PM
joshuaspence edited edge metadata.

Comprehensive list of aliases

This revision was automatically updated to reflect the committed changes.

Oh, I should've mentioned... I specifically excluded a bunch of aliases from the Ming extension because they seemed contradictory. For example, according to the documentation add() is an alias for swfmovie_add() and also swfsprite_add().