Page MenuHomePhabricator
Differential D12418

Add a linter rule for default parameters
ClosedPublic
Actions

Authored by joshuaspence on Apr 15 2015, 8:34 AM.
Tags
None
Referenced Files
F13182049: D12418.diff
Thu, May 9, 7:00 PM
Unknown Object (File)
Tue, May 7, 8:29 AM
Unknown Object (File)
Fri, May 3, 8:20 AM
Unknown Object (File)
Thu, Apr 25, 2:17 AM
Unknown Object (File)
Thu, Apr 18, 12:48 AM
Unknown Object (File)
Apr 6 2024, 6:50 PM
Unknown Object (File)
Apr 1 2024, 9:53 AM
Unknown Object (File)
Mar 30 2024, 11:42 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCc56e4a56dc2e: Add a linter rule for default parameters
Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_DEFAULT_PARAMETERS for ensuring function/method parameters with a default value are declared after those without a default value. Based on PEAR_Sniffs_Functions_ValidDefaultValueSniff.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5318
Build 5336: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29826.Apr 15 2015, 8:34 AM
joshuaspence retitled this revision from to Add a linter rule for default parameters.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2015, 8:34 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 15 2015, 11:50 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 11:50 AM
Closed by commit rARCc56e4a56dc2e: Add a linter rule for default parameters (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 20 2015, 9:28 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D12782: Fix some method signatures.May 12 2015, 8:49 PM
joshuaspence mentioned this in rPf3d382cec4d3: Fix some method signatures.May 18 2015, 8:59 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
33 lines
__tests__/
xhpast/
12 lines
4 lines

Diff 29826

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/default-parameters.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
Phabricator · Built by Phacility