Page MenuHomePhabricator
Differential D12386

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 8:08 AM.
Tags
None
Referenced Files
F14501118: D12386.id29730.diff
Sat, Jan 4, 10:49 AM
Unknown Object (File)
Tue, Dec 31, 11:51 PM
Unknown Object (File)
Tue, Dec 24, 12:42 AM
Unknown Object (File)
Thu, Dec 19, 9:24 AM
Unknown Object (File)
Thu, Dec 19, 12:36 AM
Unknown Object (File)
Tue, Dec 17, 9:57 PM
Unknown Object (File)
Fri, Dec 13, 7:53 AM
Unknown Object (File)
Tue, Dec 10, 6:00 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUaaee4009e20d: Various linter fixes
Summary

Self-explanatory

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29730.Apr 13 2015, 8:08 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 8:08 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a comment.Apr 13 2015, 9:54 AM

Hmm, it seems like the unit test failure was caused by rPHU01f860e0ec7fa01d8898487e8497293f37cbfd31.

joshuaspence updated this revision to Diff 29734.Apr 13 2015, 10:05 AM
joshuaspence edited edge metadata.

Moar changes

epriestley accepted this revision.Apr 13 2015, 2:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 2:25 PM
Closed by commit rPHUaaee4009e20d: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
writeguard/
2 lines
error/
8 lines
filesystem/
16 lines
parser/
aast/
api/
2 lines
argument/
2 lines
xhpast/
api/
2 lines
serviceprofiler/
2 lines
utils/
2 lines

Diff 29781

View Options

src/aphront/writeguard/AphrontScopedUnguardedWriteCapability.php

Loading...
View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/parser/aast/api/AASTNodeList.php

Loading...
View Options

src/parser/argument/PhutilArgumentSpecification.php

Loading...
View Options

src/parser/xhpast/api/XHPASTTree.php

Loading...
View Options

src/serviceprofiler/PhutilServiceProfiler.php

Loading...
View Options

src/utils/viewutils.php

Loading...
Phabricator · Built by Phacility