Differential D12386

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 8:08 AM.

Tags

None

Referenced Files

	F15401155: D12386.id.diff
	Mon, Mar 17, 4:01 PM

	F15400558: D12386.id29730.diff
	Mon, Mar 17, 12:31 PM

	F15399023: D12386.id29781.diff
	Mon, Mar 17, 2:29 AM

	F15395319: D12386.diff
	Sun, Mar 16, 5:33 AM

	F15393235: D12386.diff
	Sat, Mar 15, 8:35 PM

	F15384847: D12386.id29730.diff
	Fri, Mar 14, 9:00 PM

	Unknown Object (File)
	Sun, Mar 2, 1:44 PM

	Unknown Object (File)
	Mon, Feb 24, 8:29 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHUaaee4009e20d: Various linter fixes

Summary

Self-explanatory

Test Plan

Eyeball it.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5280
Build 5298: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	185 ms	PHPASTParserTestCase::testParser
	65 ms	AbstractDirectedGraphTestCase::testBestEffortTopographicSortTree
	56 ms	AbstractDirectedGraphTestCase::testCyclicGraph
	76 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure
	67 ms	AbstractDirectedGraphTestCase::testNonTreeGraph
		View Full Test Results (1 Failed · 99 Passed)

Event Timeline

joshuaspence updated this revision to Diff 29730.Apr 13 2015, 8:08 AM

joshuaspence retitled this revision from to Various linter fixes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 8:08 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Hmm, it seems like the unit test failure was caused by rPHU01f860e0ec7fa01d8898487e8497293f37cbfd31.

Moar changes

epriestley accepted this revision.Apr 13 2015, 2:25 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 2:25 PM

Closed by commit rPHUaaee4009e20d: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

writeguard/

AphrontScopedUnguardedWriteCapability.php

2 lines

error/

PhutilErrorHandler.php

8 lines

filesystem/

16 lines

parser/

aast/

api/

AASTNodeList.php

2 lines

argument/

PhutilArgumentSpecification.php

2 lines

xhpast/

api/

2 lines

serviceprofiler/

PhutilServiceProfiler.php

2 lines

utils/

2 lines

Diff 29734

src/aphront/writeguard/AphrontScopedUnguardedWriteCapability.php

Loading...

src/error/PhutilErrorHandler.php

Loading...

src/filesystem/Filesystem.php

Loading...

src/parser/aast/api/AASTNodeList.php

Loading...

src/parser/argument/PhutilArgumentSpecification.php

Loading...

src/parser/xhpast/api/XHPASTTree.php

Loading...

src/serviceprofiler/PhutilServiceProfiler.php

Loading...

src/utils/viewutils.php

Loading...