Page MenuHomePhabricator

Various linter fixes
ClosedPublic

Authored by joshuaspence on Apr 13 2015, 8:08 AM.
Tags
None
Referenced Files
F15401155: D12386.id.diff
Mon, Mar 17, 4:01 PM
F15400558: D12386.id29730.diff
Mon, Mar 17, 12:31 PM
F15399023: D12386.id29781.diff
Mon, Mar 17, 2:29 AM
F15395319: D12386.diff
Sun, Mar 16, 5:33 AM
F15393235: D12386.diff
Sat, Mar 15, 8:35 PM
F15384847: D12386.id29730.diff
Fri, Mar 14, 9:00 PM
Unknown Object (File)
Sun, Mar 2, 1:44 PM
Unknown Object (File)
Mon, Feb 24, 8:29 PM
Subscribers

Details

Summary

Self-explanatory

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 5280
Build 5298: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
185 msPHPASTParserTestCase::testParser
65 msAbstractDirectedGraphTestCase::testBestEffortTopographicSortTree
56 msAbstractDirectedGraphTestCase::testCyclicGraph
76 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
67 msAbstractDirectedGraphTestCase::testNonTreeGraph
View Full Test Results (1 Failed · 99 Passed)

Event Timeline

joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 2:25 PM
This revision was automatically updated to reflect the committed changes.