Page MenuHomePhabricator
Differential D12390

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 10:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 7:08 AM
Unknown Object (File)
Fri, May 3, 5:16 AM
Unknown Object (File)
Sat, Apr 27, 10:25 PM
Unknown Object (File)
Thu, Apr 25, 11:38 PM
Unknown Object (File)
Thu, Apr 25, 11:38 PM
Unknown Object (File)
Thu, Apr 25, 11:38 PM
Unknown Object (File)
Thu, Apr 25, 11:38 PM
Unknown Object (File)
Thu, Apr 25, 11:38 PM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPc896aeb62ed9: Various linter fixes
Summary

Apply various linter fixes.

Test Plan

Unit tests + eyeballing.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5282
Build 5300: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29736.Apr 13 2015, 10:59 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 10:59 AM
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript
joshuaspence updated this revision to Diff 30726.May 9 2015, 2:26 AM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 30877.May 14 2015, 10:54 AM

Further fixes

joshuaspence updated this revision to Diff 31090.May 19 2015, 12:48 PM

More fixes

epriestley accepted this revision.May 19 2015, 3:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:12 PM
Closed by commit rPc896aeb62ed9: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
84 lines
6 lines
applications/
audit/
constants/
14 lines
storage/
2 lines
base/
2 lines
cache/
2 lines
calendar/
storage/
2 lines
celerity/
2 lines
conduit/
method/
6 lines
query/
2 lines
2 lines
storage/
2 lines
daemon/
query/
4 lines
differential/
constants/
40 lines
24 lines
storage/
2 lines
diffusion/
data/
30 lines
query/
2 lines
pathchange/
8 lines
files/
controller/
2 lines
storage/
10 lines
fund/
storage/
36 lines
harbormaster/
storage/
4 lines
herald/
adapter/
2 lines
macro/
controller/
2 lines
metamta/
contentsource/
6 lines
storage/
2 lines
nuance/
storage/
2 lines
paste/
storage/
12 lines
phortune/
currency/
10 lines
storage/
2 lines
2 lines
phragment/
storage/
2 lines
policy/
constants/
4 lines
project/
icon/
2 lines
storage/
2 lines
6 lines
34 lines
releeph/
storage/
4 lines
28 lines
repository/
query/
2 lines
storage/
8 lines
search/
view/
3 lines
settings/
storage/
4 lines
slowvote/
storage/
40 lines
tokens/
query/
2 lines
transactions/
storage/
2 lines
infrastructure/
customfield/
field/
2 lines
daemon/
workers/
query/
2 lines
env/
12 lines
sms/
storage/
6 lines
storage/
configuration/
2 lines
lisk/
2 lines
time/
2 lines
util/
4 lines
password/
4 lines
view/
2 lines
6 lines
control/
28 lines
20 lines
form/
2 lines
2 lines
phui/
2 lines
support/
2 lines

Diff 29736

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/aphront/AphrontURIMapper.php

Loading...
View Options

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/cache/PhabricatorCaches.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/celerity/CelerityResourceGraph.php

Loading...
View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

Loading...
View Options

src/applications/conduit/storage/PhabricatorConduitToken.php

Loading...
View Options

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

Loading...
View Options

src/applications/differential/constants/DifferentialAction.php

Loading...
View Options

src/applications/differential/constants/DifferentialChangeType.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/diffusion/data/DiffusionPathChange.php

Loading...
View Options

src/applications/diffusion/query/DiffusionRenameHistoryQuery.php

Loading...
View Options

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/fund/storage/FundInitiativeTransaction.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroMemeController.php

Loading...
View Options

src/applications/metamta/contentsource/PhabricatorContentSource.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/nuance/storage/NuanceItem.php

Loading...
View Options

src/applications/paste/storage/PhabricatorPasteTransaction.php

Loading...
View Options

src/applications/phortune/currency/PhortuneCurrency.php

Loading...
View Options

src/applications/phortune/storage/PhortuneAccount.php

Loading...
View Options

src/applications/phortune/storage/PhortuneCart.php

Loading...
View Options

src/applications/phragment/storage/PhragmentFragment.php

Loading...
View Options

src/applications/policy/constants/PhabricatorPolicies.php

Loading...
View Options

src/applications/project/icon/PhabricatorProjectIcon.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumnTransaction.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequest.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequestTransaction.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

Loading...
View Options

src/applications/search/view/PhabricatorSearchResultView.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

Loading...
View Options

src/applications/tokens/query/PhabricatorTokenCountQuery.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/infrastructure/sms/storage/PhabricatorSMS.php

Loading...
View Options

src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAOSet.php

Loading...
View Options

src/infrastructure/time/PhabricatorTime.php

Loading...
View Options

src/infrastructure/util/PhabricatorHash.php

Loading...
View Options

src/infrastructure/util/password/PhabricatorPasswordHasher.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/AphrontJavelinView.php

Loading...
View Options

src/view/control/AphrontCursorPagerView.php

Loading...
View Options

src/view/control/AphrontPagerView.php

Loading...
View Options

src/view/form/PHUIInfoView.php

Loading...
View Options

src/view/form/PHUIPagedFormView.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

support/PhabricatorStartup.php

Loading...
Phabricator · Built by Phacility