Fixes T7486. Implement HTTP response messages such as 200 OK and 404 Not Found. The status codes were taken from http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7486: All responses use "OK" as the status text
- Commits
- Restricted Diffusion Commit
rPb2c23d88e8f9: Implement HTTP response messages
Navigated to /foo and saw the response showing 404 Not Found in the Network tab of Chrome.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5166 Build 5184: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/aphront/response/AphrontResponse.php | ||
|---|---|---|
| 126 | Maybe this should return "Status Unknown" or similar? In the spirit of the project, I also recommend inclusion of 418. | |
| src/aphront/response/AphrontResponse.php | ||
|---|---|---|
| 126 | I actually disagree. I think that if we don't know the status message then we should leave it blank. This might allow the client to figure out the status message based on the response code (which Chrome seems to be able to do to some extent, because we have until now been returning 200 instead of 200 OK). | |