Page MenuHomePhabricator
Differential D12268

Lift handling of Herald "email" effect to Adapter
ClosedPublic
Actions

Authored by epriestley on Apr 4 2015, 12:11 AM.
Tags
None
Referenced Files
F14769033: D12268.diff
Thu, Jan 23, 7:50 PM
F14761441: D12268.diff
Thu, Jan 23, 1:22 AM
Unknown Object (File)
Tue, Jan 21, 7:07 PM
Unknown Object (File)
Tue, Jan 21, 11:46 AM
Unknown Object (File)
Sun, Jan 19, 1:23 AM
Unknown Object (File)
Sun, Jan 19, 12:13 AM
Unknown Object (File)
Sat, Jan 18, 12:21 AM
Unknown Object (File)
Tue, Jan 7, 10:37 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7731: Make "Send me an email" force mail delivery through notification preferences
Commits
Restricted Diffusion Commit
rPa40748a46cb5: Lift handling of Herald "email" effect to Adapter
Summary

Ref T7731. Every adapter subclass currently implements this effect in an essentially identical way.

Some day far from now the effects will be modular and this mess will vanish completely, but reduce its sprawl for now.

Test Plan

I'll test this thoroughly at the end of the change sequence since writing rules is a pain.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29466.Apr 4 2015, 12:11 AM
epriestley retitled this revision from to Lift handling of Herald "email" effect to Adapter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 4 2015, 12:11 AM
epriestley updated this object.Apr 5 2015, 5:39 PM
epriestley added a task: T7731: Make "Send me an email" force mail delivery through notification preferences.
btrahan accepted this revision.Apr 6 2015, 4:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 4:10 PM
Closed by commit rPa40748a46cb5: Lift handling of Herald "email" effect to Adapter (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
3 lines
diffusion/
herald/
13 lines
herald/
adapter/
17 lines
13 lines
22 lines
13 lines
phriction/
herald/
15 lines

Diff 29539

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
Phabricator · Built by Phacility