Page MenuHomePhabricator

Lift handling of Herald "email" effect to Adapter
ClosedPublic

Authored by epriestley on Apr 4 2015, 12:11 AM.
Tags
None
Referenced Files
F17944577: D12268.id.diff
Thu, Jul 31, 10:33 AM
F17924378: D12268.diff
Wed, Jul 30, 9:55 AM
Unknown Object (File)
Jun 29 2025, 9:02 AM
Unknown Object (File)
May 31 2025, 1:30 PM
Unknown Object (File)
May 29 2025, 9:03 AM
Unknown Object (File)
May 28 2025, 8:46 AM
Unknown Object (File)
May 14 2025, 5:15 AM
Unknown Object (File)
May 7 2025, 3:30 AM
Subscribers

Details

Summary

Ref T7731. Every adapter subclass currently implements this effect in an essentially identical way.

Some day far from now the effects will be modular and this mess will vanish completely, but reduce its sprawl for now.

Test Plan

I'll test this thoroughly at the end of the change sequence since writing rules is a pain.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Lift handling of Herald "email" effect to Adapter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 4:10 PM
This revision was automatically updated to reflect the committed changes.