Page MenuHomePhabricator
Differential D12284

Utilize `phutil_json_decode`
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:40 AM.
Tags
None
Referenced Files
F15548497: D12284.id29507.diff
Sun, Apr 27, 12:09 AM
F15542428: D12284.id.diff
Fri, Apr 25, 4:44 PM
F15531964: D12284.id.diff
Wed, Apr 23, 2:00 PM
F15531782: D12284.id29487.diff
Wed, Apr 23, 12:56 PM
F15528718: D12284.diff
Tue, Apr 22, 1:24 PM
F15487530: D12284.id.diff
Thu, Apr 10, 2:55 PM
F15465701: D12284.id.diff
Wed, Apr 2, 10:13 PM
F15461752: D12284.id29507.diff
Tue, Apr 1, 11:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU5a5966560e25: Utilize `phutil_json_decode`
Summary

Use phutil_json_decode instead of json_decode to throw a more tailored exception.

Test Plan

Broke xhpast to return invalid JSON... saw a PhutilProxyException thrown.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5142
Build 5160: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29487.Apr 5 2015, 9:40 AM
joshuaspence retitled this revision from to Utilize `phutil_json_decode`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:40 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:20 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 5 2015, 12:20 PM
joshuaspence updated this object.Apr 5 2015, 12:31 PM
joshuaspence edited edge metadata.
joshuaspence edited the test plan for this revision. (Show Details)Apr 5 2015, 12:34 PM
joshuaspence updated this revision to Diff 29506.Apr 5 2015, 12:35 PM

pht

Herald added a subscriber: Korvin. · View Herald TranscriptApr 5 2015, 12:35 PM
Closed by commit rPHU5a5966560e25: Utilize `phutil_json_decode` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
10 lines

Diff 29506

View Options

src/parser/xhpast/api/XHPASTTree.php

Loading...
Phabricator · Built by Phacility