Page MenuHomePhabricator

Utilize `phutil_json_decode`
ClosedPublic

Authored by joshuaspence on Apr 5 2015, 9:40 AM.
Tags
None
Referenced Files
F15465701: D12284.id.diff
Wed, Apr 2, 10:13 PM
F15461752: D12284.id29507.diff
Tue, Apr 1, 11:00 AM
F15420839: D12284.id29506.diff
Fri, Mar 21, 6:13 PM
F15416451: D12284.id29507.diff
Thu, Mar 20, 11:10 AM
F15412485: D12284.id29487.diff
Wed, Mar 19, 1:13 PM
F15410621: D12284.id29506.diff
Wed, Mar 19, 7:55 AM
F15400966: D12284.diff
Mon, Mar 17, 3:00 PM
F15385664: D12284.diff
Fri, Mar 14, 11:06 PM
Subscribers

Details

Summary

Use phutil_json_decode instead of json_decode to throw a more tailored exception.

Test Plan

Broke xhpast to return invalid JSON... saw a PhutilProxyException thrown.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5142
Build 5160: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Utilize `phutil_json_decode`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 5 2015, 12:20 PM
This revision was automatically updated to reflect the committed changes.