Paths

Table of Contentst

Differential D12284

Utilize `phutil_json_decode`
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:40 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU5a5966560e25: Utilize `phutil_json_decode`

Summary

Use phutil_json_decode instead of json_decode to throw a more tailored exception.

Test Plan

Broke xhpast to return invalid JSON... saw a PhutilProxyException thrown.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5128
Build 5146: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29487.Apr 5 2015, 9:40 AM

joshuaspence retitled this revision from to Utilize `phutil_json_decode`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:40 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Apr 5 2015, 12:20 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Apr 5 2015, 12:20 PM

joshuaspence updated this object.Apr 5 2015, 12:31 PM

joshuaspence edited edge metadata.

joshuaspence edited the test plan for this revision. (Show Details)Apr 5 2015, 12:34 PM

pht

Herald added a subscriber: Korvin. · View Herald TranscriptApr 5 2015, 12:35 PM

Closed by commit rPHU5a5966560e25: Utilize `phutil_json_decode` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

api/

XHPASTTree.php

8 lines

Diff 29487

View Options

src/parser/xhpast/api/XHPASTTree.php

Utilize `phutil_json_decode`ClosedPublicActions