Paths

Table of Contentst

Differential D12287

Simplify `AASTNodeList::selectDescendantsOfType`
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:55 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType`

Summary

Rewrite AASTNodeList::selectDescendantsOfType to just call AASTNodeList::selectDescendantsOfTypes, minimizing code duplication.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5131
Build 5149: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29490.Apr 5 2015, 9:55 AM

joshuaspence retitled this revision from to Simplify `AASTNodeList::selectDescendantsOfType`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:55 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 5 2015, 12:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2015, 12:17 PM

Closed by commit rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

AASTNodeList.php

6 lines

Diff 29490

View Options

src/parser/aast/api/AASTNodeList.php

Simplify `AASTNodeList::selectDescendantsOfType`ClosedPublicActions