Page MenuHomePhabricator

Improve handle loading semantics for tokenizers
ClosedPublic

Authored by epriestley on Apr 2 2015, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:16 PM
Unknown Object (File)
Tue, Apr 9, 4:53 PM
Unknown Object (File)
Sun, Mar 31, 6:35 PM
Unknown Object (File)
Sun, Mar 24, 10:28 AM
Unknown Object (File)
Mar 5 2024, 4:11 PM
Unknown Object (File)
Feb 12 2024, 7:31 AM
Unknown Object (File)
Feb 3 2024, 2:52 AM
Unknown Object (File)
Jan 31 2024, 6:42 PM
Subscribers

Details

Summary

Ref T7689. Fixes T7688. When there are a bunch of tokenizers with different values of the same object type (e.g. 5 tokenizers with users a, b, c, d, e) we currently issue 5 separate queries to load their handles.

Improve this behavior in the common case so we can usually batch these loads.

Test Plan
  • In Maniphest, set the various search fields to different values.
  • Used DarkConsole to examine query plan.
  • Saw fewer queries after patch than before.

Diff Detail

Repository
rP Phabricator
Branch
tok20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5101
Build 5119: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve handle loading semantics for tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.