Fixes T7730. Herald queries used to incorrectly label object rules as global rules. An object rule is now labeled as such.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7730: Herald queries show object rules as global rules
- Commits
- Restricted Diffusion Commit
rP1ae1cdd7bac4: Herald queries correctly label Object Rules
Made a few rules and looked at the herald query page.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- herald-rule-labels
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5098 Build 5116: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Side note: What are your thoughts on by-lines in this results list?
Only the personal rules by by-lines (the rule author). Object and global rules do not get anything.
What do you think of having object rules say "Triggered by: #project | rREPO"?
Not precisely sure how to go about doing this given that array $handles is only loaded with the rule author PHID.
Comment Actions
I'd be open to various different approaches here, but I tend to think this is a good one. One consideration is that the object list might be very long, which would make it awkward to display here.
(Handles will get easier to use soon, after T7689.)