Page MenuHomePhabricator
Differential D12259

Herald queries correctly label Object Rules
ClosedPublic
Actions

Authored by epkugelmass on Apr 2 2015, 4:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 2:19 PM
Unknown Object (File)
Thu, Apr 4, 7:06 AM
Unknown Object (File)
Thu, Apr 4, 7:06 AM
Unknown Object (File)
Thu, Apr 4, 6:27 AM
Unknown Object (File)
Thu, Apr 4, 6:01 AM
Unknown Object (File)
Mon, Apr 1, 9:56 AM
Unknown Object (File)
Mar 18 2024, 3:37 AM
Unknown Object (File)
Mar 6 2024, 5:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7730: Herald queries show object rules as global rules
Commits
Restricted Diffusion Commit
rP1ae1cdd7bac4: Herald queries correctly label Object Rules
Summary

Fixes T7730. Herald queries used to incorrectly label object rules as global rules. An object rule is now labeled as such.

Test Plan

Made a few rules and looked at the herald query page.

Diff Detail

Repository
rP Phabricator
Branch
herald-rule-labels
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5098
Build 5116: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epkugelmass updated this revision to Diff 29442.Apr 2 2015, 4:18 AM
epkugelmass retitled this revision from to Herald queries correctly label Object Rules.
epkugelmass updated this object.
epkugelmass edited the test plan for this revision. (Show Details)
epkugelmass added a reviewer: epriestley.
epkugelmass added a task: T7730: Herald queries show object rules as global rules.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 2 2015, 4:18 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epkugelmass added a comment.Apr 2 2015, 4:22 AM

Side note: What are your thoughts on by-lines in this results list?
Only the personal rules by by-lines (the rule author). Object and global rules do not get anything.
What do you think of having object rules say "Triggered by: #project | rREPO"?
Not precisely sure how to go about doing this given that array $handles is only loaded with the rule author PHID.

epriestley accepted this revision.Apr 2 2015, 12:00 PM
epriestley edited edge metadata.

I'd be open to various different approaches here, but I tend to think this is a good one. One consideration is that the object list might be very long, which would make it awkward to display here.

(Handles will get easier to use soon, after T7689.)

This revision is now accepted and ready to land.Apr 2 2015, 12:00 PM
Closed by commit rP1ae1cdd7bac4: Herald queries correctly label Object Rules (authored by epkugelmass, committed by epriestley). · Explain WhyApr 2 2015, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
query/
2 lines

Diff 29442

View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...
Phabricator · Built by Phacility