Fixes T7521. See discussion in T7521#104969 about alternatives.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7521: `arc land` should work even when the repo has untracked files
- Created this revision in git with random junk in working copy.
- If we proceed, I'll test it more carefully in hg and svn.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- untrack1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5095 Build 5113: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Specifically I don't think you should be so hastily removing this feature. I can see people upgrading Arcanist and getting tripped up because it's no longer telling them when they're about to do bad things (and that will be perceived as Arcanists fault for no longer telling them).
Comment Actions
I am not sure that this behaviour should be removed. The behaviour of arc diff prior to D11843 appeared to be add untracked files using a prompt (admitedly separate to adding uncommitted files), which was changed to move a single prompt. I don't believe that leaving untracked files in the working copy is a desirable behaviour.
