Page MenuHomePhabricator

Prompt users to ignore or abort on untracked files
ClosedPublic

Authored by epriestley on Apr 2 2015, 3:15 AM.

Details

Summary

Fixes T7521. This separates things into two prompts and doesn't try to automatically add untracked files.

This also fixes T7512, or at least I can't reproduce it after this change.

Test Plan
  • Ran arc diff in a git directory with untracked files.
  • Ran arc diff in a svn directory with untracked files.
  • Ran arc diff in a hg directory with untracked files.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Prompt users to ignore or abort on untracked files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • SVN has no unstaged/uncommitted files so we never actually reach the prompt anymore there; remove some code.
  • Make "--add-all" documentation more accurate.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 7:57 PM
This revision was automatically updated to reflect the committed changes.