Page MenuHomePhabricator
Differential D12258

Prompt users to ignore or abort on untracked files
ClosedPublic
Actions

Authored by epriestley on Apr 2 2015, 3:15 AM.

Details

Reviewers
btrahan
Maniphest Tasks
T7512: "Select a Default Commit Range" prompt gets interleaved with "Untracked files in working copy" question
T7521: `arc land` should work even when the repo has untracked files
Commits
rARC8bbcbdd3b660: Prompt users to ignore or abort on untracked files
Summary

Fixes T7521. This separates things into two prompts and doesn't try to automatically add untracked files.

This also fixes T7512, or at least I can't reproduce it after this change.

Test Plan
  • Ran arc diff in a git directory with untracked files.
  • Ran arc diff in a svn directory with untracked files.
  • Ran arc diff in a hg directory with untracked files.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29441.Apr 2 2015, 3:15 AM
epriestley retitled this revision from to Prompt users to ignore or abort on untracked files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7521: `arc land` should work even when the repo has untracked files.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 2 2015, 3:15 AM
epriestley updated this object.Apr 2 2015, 3:23 AM
epriestley edited the test plan for this revision. (Show Details)
epriestley added a task: T7512: "Select a Default Commit Range" prompt gets interleaved with "Untracked files in working copy" question.
epriestley mentioned this in T7521: `arc land` should work even when the repo has untracked files.Apr 2 2015, 3:33 AM
epriestley updated this revision to Diff 29444.Apr 2 2015, 12:56 PM
  • SVN has no unstaged/uncommitted files so we never actually reach the prompt anymore there; remove some code.
epriestley updated this revision to Diff 29452.Apr 2 2015, 5:00 PM
  • Make "--add-all" documentation more accurate.
btrahan accepted this revision.Apr 2 2015, 7:57 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 7:57 PM
btrahan mentioned this in D12256: Remove all checks for untracked files from Arcanist.Apr 2 2015, 7:57 PM
Closed by commit rARC8bbcbdd3b660: Prompt users to ignore or abort on untracked files (authored by epriestley). · Explain WhyApr 2 2015, 8:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
internationalization/
5 lines
workflow/
3 lines
87 lines

Diff 29453

View Options

src/internationalization/ArcanistUSEnglishTranslation.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility