Page MenuHomePhabricator
Differential D12253

Fix an issue where we would try to release an unheld lock
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 11:23 PM.
Tags
None
Referenced Files
F13218958: D12253.diff
Sat, May 18, 2:11 PM
F13216669: D12253.diff
Sat, May 18, 1:51 AM
F13201088: D12253.id29436.diff
Tue, May 14, 7:54 AM
F13200255: D12253.diff
Mon, May 13, 10:44 PM
F13182477: D12253.diff
Thu, May 9, 11:30 PM
Unknown Object (File)
Mon, May 6, 2:14 AM
Unknown Object (File)
Fri, May 3, 5:24 AM
Unknown Object (File)
Thu, May 2, 5:36 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7484: Lock is not locked by this process
Commits
Restricted Diffusion Commit
rPe9886c4353df: Fix an issue where we would try to release an unheld lock
Summary

Fixes T7484. If the lock failed, we'd still try to unlock it, which is incorrect.

Test Plan

Ran two bin/repository update X in different windows, got proper LockException instead of indirect symptomatic "not locked by this process" exception.

Diff Detail

Repository
rP Phabricator
Branch
lock1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php:74XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 5092
Build 5110: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29433.Apr 1 2015, 11:23 PM
epriestley retitled this revision from to Fix an issue where we would try to release an unheld lock.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7484: Lock is not locked by this process.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 11:23 PM
epriestley mentioned this in T7484: Lock is not locked by this process.Apr 1 2015, 11:24 PM
btrahan accepted this revision.Apr 2 2015, 12:08 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 12:08 AM
Closed by commit rPe9886c4353df: Fix an issue where we would try to release an unheld lock (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2015, 12:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
management/
52 lines

Diff 29433

View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

Loading...
Phabricator · Built by Phacility