Fix an issue where we would try to release an unheld lock
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 11:23 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7484: Lock is not locked by this process

Commits

Restricted Diffusion Commit
rPe9886c4353df: Fix an issue where we would try to release an unheld lock

Summary

Fixes T7484. If the lock failed, we'd still try to unlock it, which is incorrect.

Test Plan

Ran two bin/repository update X in different windows, got proper LockException instead of indirect symptomatic "not locked by this process" exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29433.Apr 1 2015, 11:23 PM

epriestley retitled this revision from to Fix an issue where we would try to release an unheld lock.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7484: Lock is not locked by this process.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 11:23 PM

epriestley mentioned this in T7484: Lock is not locked by this process.Apr 1 2015, 11:24 PM

btrahan accepted this revision.Apr 2 2015, 12:08 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 2 2015, 12:08 AM

Closed by commit rPe9886c4353df: Fix an issue where we would try to release an unheld lock (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2015, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

management/

PhabricatorRepositoryManagementUpdateWorkflow.php

52 lines

Diff 29436

View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

Fix an issue where we would try to release an unheld lockClosedPublicActions