Page MenuHomePhabricator

Remove all application-specific reply handler domains
ClosedPublic

Authored by epriestley on Mar 31 2015, 11:33 PM.
Tags
None
Referenced Files
F13209490: D12231.id29382.diff
Fri, May 17, 12:32 AM
F13195227: D12231.diff
Sun, May 12, 10:14 PM
Unknown Object (File)
Fri, May 3, 2:33 AM
Unknown Object (File)
Mon, Apr 29, 1:14 PM
Unknown Object (File)
Apr 11 2024, 7:02 AM
Unknown Object (File)
Apr 9 2024, 12:40 PM
Unknown Object (File)
Apr 9 2024, 11:58 AM
Unknown Object (File)
Apr 7 2024, 6:11 AM
Subscribers

Details

Summary

Ref T7199. These were a bad idea which got copy-pasted a bunch.

  • There is zero reason to ever set these to different things.
  • Unsurprisingly, I don't know of any install which has them set to different things.

Unless I've completely forgotten about it, this option was not motivated by some obscure business need, it was just a bad decision which didn't catch anyone's attention at the time.

We partially remedied the mistake at some point by introducing metamta.reply-handler-domain, which works as a default for all applications, but never cleaned this mess up.

Test Plan

Sent some mail from applications, verified it picked up appropraite reply handler domains.

Diff Detail

Repository
rP Phabricator
Branch
mcom4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5066
Build 5084: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove all application-specific reply handler domains.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Be slightly less aggressive about removing Macro config, it still has one option.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2015, 11:38 PM
This revision was automatically updated to reflect the committed changes.