Page MenuHomePhabricator

Remove all application-specific reply handler class overrides
ClosedPublic

Authored by epriestley on Apr 1 2015, 12:01 AM.
Tags
None
Referenced Files
F18505270: D12233.id.diff
Fri, Sep 5, 12:31 AM
F18496941: D12233.diff
Thu, Sep 4, 5:48 PM
F18467596: D12233.diff
Tue, Sep 2, 1:08 PM
F18103022: D12233.id29392.diff
Aug 10 2025, 1:09 AM
F17919690: D12233.id29389.diff
Jul 30 2025, 2:49 AM
F17892050: D12233.id.diff
Jul 29 2025, 4:26 AM
F17870754: D12233.diff
Jul 28 2025, 2:41 PM
F17828728: D12233.id29389.diff
Jul 26 2025, 9:29 AM
Subscribers

Details

Summary

Ref T7199. In the vein of D12231, these options were a bad idea.

  • They once served a very narrow, Facebook-specific need (see T1992), except even Facebook only used the Differential setting AFAIK.
  • Outside of that special case, they are unused and essentially unusable (generally speaking, they do not meaningfully implement anything modular or replaceable).
  • I have no knowledge of any install ever changing these settings, and can imagine no reason why they would.

Moving forward:

  • If they really need to, they can fork locally and chagne one line.
  • I expect "!actions" to make mail at least somewhat more modular soon, anyway.
  • Any derived handlers would break after T7199 and need to be rewritten anyway, so this is just taking advantage of a BC break to do cleanup.
Test Plan
  • Grepped for removed configuration.
  • Sent some mail from applications, verified the reply handlers set proper reply addresses.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove all application-specific reply handler class overrides.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.Apr 1 2015, 12:10 AM
This revision was automatically updated to reflect the committed changes.