Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
F15502789: D12205.id29328.diff
Mon, Apr 14, 4:19 AM
F15495279: D12205.id29328.diff
Sun, Apr 13, 3:37 AM
F15483739: D12205.id29354.diff
Wed, Apr 9, 2:06 PM
F15480695: D12205.id.diff
Tue, Apr 8, 3:45 PM
F15477013: D12205.diff
Mon, Apr 7, 11:25 AM
F15434818: D12205.id.diff
Tue, Mar 25, 5:37 AM
F15423591: D12205.id29328.diff
Sat, Mar 22, 4:12 PM
F15378140: D12205.id29328.diff
Mar 13 2025, 1:10 PM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.