Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
F20682230: D12205.diff
Mon, Jun 22, 1:19 AM
F20679875: D12205.id29354.diff
Sun, Jun 21, 11:53 PM
F20660170: D12205.id.diff
Sun, Jun 21, 9:03 AM
Unknown Object (File)
Apr 22 2026, 5:45 AM
Unknown Object (File)
Apr 15 2026, 9:25 AM
Unknown Object (File)
Mar 5 2026, 7:10 AM
Unknown Object (File)
Mar 1 2026, 11:51 AM
Unknown Object (File)
Feb 4 2026, 12:06 AM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.