Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:21 AM
Unknown Object (File)
Fri, Apr 19, 8:07 PM
Unknown Object (File)
Fri, Apr 12, 9:16 PM
Unknown Object (File)
Fri, Apr 12, 12:14 AM
Unknown Object (File)
Sun, Apr 7, 4:39 AM
Unknown Object (File)
Sat, Apr 6, 4:11 AM
Unknown Object (File)
Thu, Apr 4, 4:22 AM
Unknown Object (File)
Mar 12 2024, 7:53 PM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Branch
param3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phid/view/PHUIHandleListView.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5036
Build 5054: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.