Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
F19095544: D12205.diff
Thu, Dec 4, 5:33 AM
F18952690: D12205.diff
Nov 12 2025, 6:23 AM
F18896479: D12205.id.diff
Nov 7 2025, 4:07 PM
F18877811: D12205.diff
Nov 6 2025, 12:05 PM
F18849549: D12205.id29328.diff
Oct 30 2025, 10:37 AM
F18846386: D12205.id29354.diff
Oct 29 2025, 6:43 PM
F18818748: D12205.id29354.diff
Oct 22 2025, 2:08 AM
F18784790: D12205.id29328.diff
Oct 13 2025, 3:12 PM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Branch
param3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phid/view/PHUIHandleListView.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5036
Build 5054: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.