Page MenuHomePhabricator
Differential D12177

Conpherence - fix missing method
ClosedPublic
Actions

Authored by btrahan on Mar 26 2015, 8:34 PM.
Tags
None
Referenced Files
F13106012: D12177.diff
Sat, Apr 27, 6:08 PM
Unknown Object (File)
Sun, Apr 21, 1:21 PM
Unknown Object (File)
Thu, Apr 18, 10:15 AM
Unknown Object (File)
Tue, Apr 16, 12:44 PM
Unknown Object (File)
Tue, Apr 16, 12:44 PM
Unknown Object (File)
Tue, Apr 16, 12:39 PM
Unknown Object (File)
Tue, Apr 16, 12:07 PM
Unknown Object (File)
Thu, Apr 11, 10:02 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T7669: Can't create Conpherences
Commits
Restricted Diffusion Commit
rPd2e59b228975: Conpherence - fix missing method
Summary

Fixes T7669. Broken by D12163 re-factoring and foolihardiness of test coverage. Notably / interestingly, this was broken before D12163 from not implementing policy correctly, so Conpherence has been broken for a bit with few reports.

Test Plan

had user send himself a message

Diff Detail

Repository
rP Phabricator
Branch
T7669
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4998
Build 5016: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29264.Mar 26 2015, 8:34 PM
btrahan added a task: T7669: Can't create Conpherences.
btrahan retitled this revision from to Conpherence - fix missing method.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 26 2015, 8:34 PM
chad accepted this revision.Mar 26 2015, 8:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 26 2015, 8:35 PM
epriestley accepted this revision.Mar 26 2015, 8:35 PM
epriestley edited edge metadata.
Closed by commit rPd2e59b228975: Conpherence - fix missing method (authored by btrahan, committed by btrahan). · Explain WhyMar 26 2015, 8:35 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a comment.Mar 26 2015, 8:36 PM

Test coverage still feels so good though! :D

btrahan mentioned this in D12178: Conpherence - get lots of rooms stuff hooked up nicely.Mar 26 2015, 11:13 PM
btrahan mentioned this in rP39fa190c15ce: Conpherence - get lots of rooms stuff hooked up nicely.Mar 26 2015, 11:37 PM

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
conduit/
2 lines
controller/
2 lines

Diff 29264

View Options

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNewController.php

Loading...
Phabricator · Built by Phacility