Conpherence - get lots of rooms stuff hooked up nicely
ClosedPublic
Actions

Authored by btrahan on Mar 26 2015, 11:13 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7566: Implement "Rooms" in Conpherence

Commits

Restricted Diffusion Commit
rP39fa190c15ce: Conpherence - get lots of rooms stuff hooked up nicely

Summary

Ref T7566. This does a big chunk of what's left

Main view
- "Rooms" sub header
  - 5 Rooms shown at a time, with room you're looking at in the top on page load
    - e.g. viewing /conpherence/x/ the room x is at top always
    - solves corner case of when you have yet to "join" the room
  - "See More" link takes you to application search for rooms you have participated in
  - if no rooms, there is a "Create Room" and "Find Rooms" links.
- "Messages" sub header
  - same as before
- policy icons showing up in the menu
Durable column view - still just the latest N, no changes really there
Transactions - special cased rendering to try to say room vs thread as appropos
Bug fix - we weren't recording the initial participants transaction post D12177 / D12163. This fixes that.

Should probably test pagination, and if you want to show more than 5 rooms of have it behave more like messages (where you can wind up in the middle of a paginated list) that will be more work. Also, if lots of messages / rooms (100 is the limit) we might not display rooms if we're supposed to. Yay whale usage! :D

Test Plan

made a new room - success. made a new message - success. viewed a room from /conpherenece/room/ i wasn't a participant in and noted it showed up at the top of the five rooms. clicked around rooms and stuff loaded nicely.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29269.Mar 26 2015, 11:13 PM

btrahan added a task: T7566: Implement "Rooms" in Conpherence.

btrahan retitled this revision from to Conpherence - get lots of rooms stuff hooked up nicely.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 26 2015, 11:13 PM

Screen_Shot_2015-03-26_at_4.16.52_PM.png (1×2 px, 527 KB)

epriestley accepted this revision.Mar 26 2015, 11:23 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/conpherence/storage/ConpherenceTransaction.php
55–56	This stuff isn't translatable because, e.g., the verb may depend on the gender of the noun or something in various moon languages. It has to be: if ($is_room) { pht('...this room...'); } else { pht('...this thread...'); }
src/applications/conpherence/view/ConpherenceThreadListView.php
37	`$grouped[true]` might not exist if there are no rooms?
57	Likewise, this might not exist if there are no threads?
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
620–639 ↗	(On Diff #29269)	These aren't really translatable either and are basically just placeholders which should be getting overridden by subclasses.