Paths

Table of Contentst

Differential D12129

Lift inline state transactions into core (in Diffusion)
ClosedPublic
Actions

Authored by epriestley on Mar 22 2015, 1:29 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6403: Make application customization of builtin transaction types optional
T1460: Add "Done" link to an inline comment

Commits

Restricted Diffusion Commit
rP8c053f02a7cf: Lift inline state transactions into core (in Diffusion)

Summary

Ref T1460. Ref T6403. Replace Diffusion::INLINEDONE with Transactions::INLINESTATE and generalize things enough that we can lift it into core.

The next change will lift Differential's similar implementation into the core.

Also start implementing a fix for T6403, providing an alternate hook for optional builtin transactions.

Test Plan

Changed inline state in Diffusion.

Diff Detail

Repository

rP Phabricator

Branch

uni41

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:520	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 4943
Build 4961: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29155.Mar 22 2015, 1:29 PM

epriestley retitled this revision from to Lift inline state transactions into core (in Diffusion).

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T1460: Add "Done" link to an inline comment, T6403: Make application customization of builtin transaction types optional.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 22 2015, 1:29 PM

epriestley mentioned this in D12130: Lift inline comment state transactions into core (in Differential).Mar 22 2015, 1:38 PM

btrahan accepted this revision.Mar 23 2015, 5:23 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 5:23 PM

Closed by commit rP8c053f02a7cf: Lift inline state transactions into core (in Diffusion) (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2015, 12:27 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPdd3afe2aa2ae: Lift inline comment state transactions into core (in Differential).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

55 lines

storage/

PhabricatorAuditTransaction.php

61 lines

transactions/

constants/

PhabricatorTransactions.php

11 lines

editor/

PhabricatorApplicationTransactionEditor.php

22 lines

storage/

PhabricatorApplicationTransaction.php

63 lines

Diff 29155

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

View Options

src/applications/transactions/constants/PhabricatorTransactions.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Lift inline state transactions into core (in Diffusion)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29155

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/audit/storage/PhabricatorAuditTransaction.php

src/applications/transactions/constants/PhabricatorTransactions.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Lift inline state transactions into core (in Diffusion)
ClosedPublic
Actions

Revision Contents
Changeset List