Page MenuHomePhabricator
Differential D12129

Lift inline state transactions into core (in Diffusion)
ClosedPublic
Actions

Authored by epriestley on Mar 22 2015, 1:29 PM.
Tags
None
Referenced Files
F13092776: D12129.id.diff
Thu, Apr 25, 5:15 AM
F13092732: D12129.id29186.diff
Thu, Apr 25, 4:56 AM
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Unknown Object (File)
Tue, Apr 16, 5:16 AM
Unknown Object (File)
Fri, Apr 12, 4:15 AM
Unknown Object (File)
Fri, Apr 12, 4:15 AM
Unknown Object (File)
Wed, Apr 10, 3:43 PM
Unknown Object (File)
Tue, Apr 9, 2:33 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP8c053f02a7cf: Lift inline state transactions into core (in Diffusion)
Summary

Ref T1460. Ref T6403. Replace Diffusion::INLINEDONE with Transactions::INLINESTATE and generalize things enough that we can lift it into core.

The next change will lift Differential's similar implementation into the core.

Also start implementing a fix for T6403, providing an alternate hook for optional builtin transactions.

Test Plan

Changed inline state in Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
55 lines
storage/
61 lines
transactions/
constants/
11 lines
editor/
22 lines
storage/
63 lines

Diff 29186

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility