Page MenuHomePhabricator

Fix improper selection of the chunk engine as a writable engine
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:30 PM.
Tags
None
Referenced Files
F19136041: D12110.diff
Wed, Dec 10, 9:15 AM
F19080723: D12110.id29130.diff
Tue, Dec 2, 2:13 AM
F18992059: D12110.diff
Nov 19 2025, 12:04 AM
F18863986: D12110.diff
Nov 3 2025, 2:12 AM
F18856960: D12110.diff
Nov 1 2025, 12:25 PM
F18802310: D12110.id29130.diff
Oct 17 2025, 6:42 PM
F18799320: D12110.id29133.diff
Oct 17 2025, 1:12 PM
F18799311: D12110.id29133.diff
Oct 17 2025, 1:10 PM
Subscribers

Details

Summary

Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan
  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Diff Detail

Repository
rP Phabricator
Branch
upload1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4923
Build 4941: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix improper selection of the chunk engine as a writable engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.